Merged
Conversation
fnhipster
previously approved these changes
Mar 17, 2026
jaumecapdevila
force-pushed
the
fix-lang
branch
from
21cf6b4 to
6d57d56
Compare
jaumecapdevila
previously approved these changes
Mar 18, 2026
jaumecapdevila
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Provider to merge user-provided
langDefinitionswith the drop-in's default definitions, enabling label/placeholder overrides via the initializer API.Problem
The Provider passes only the bundled
langDefinitionstoUIProvider. User-provided values fromconfigare never read or merged, so any custom label overrides passed through the initializer are silently ignored.This affects all customers using the Template drop-in.
See USF-3826
Changes
configfrom'../api'anddeepmergefrom'@adobe-commerce/elsie/lib'userLangDefinitionsfromconfigUIProvider