Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
timkim
left a comment
There was a problem hiding this comment.
Hmmm, I thought we already have a similar block as embed?
https://github.com/adobe/adobe-io-website/blob/main/hlx_statics/blocks/embed/embed.js
Perhaps when we were creating the jira ticket for this, it was named Media in gatsby but Embed in eds so we didn't notice it was the same?
@timkim , In Embedded You tube video is only possible to added , but in Media blocks We implement Both You Tube and Local Videos to be added. Can I remove the media blocks or it is ok with you for this update? |
|
Oh I see. Hmm our intern was actually working on embedding video from multiple sources (youtube, vimeo, tikitok, insta, local etc). I think we may end up using @Elisha-Edme work : #155. Sorry for the overlap! But if @Elisha-Edme , maybe you can browse the files in this pr and see if you missed anything that you'd like to add. |
|
@manimitrah Do you have a test file/link that you could add so that I could see the links that are allowed in this media block? It seems super similar to my PR but I'm not sure if local videos are a different format. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: