Skip to content

feat: button migration#585

Merged
fkakatie merged 4 commits intomainfrom
button-migration
Feb 19, 2026
Merged

feat: button migration#585
fkakatie merged 4 commits intomainfrom
button-migration

Conversation

@fkakatie
Copy link
Copy Markdown
Member

@fkakatie fkakatie commented Feb 5, 2026

Migrate button decoration from aem-lib to boilerplate

Test URLs:

Summary

Moves decorateButtons from aem-lib to boilerplate with improved opt-in behavior and visual hierarchy.

Why: Button decoration touches styles and should live in the editable boilerplate, not the protected aem-lib. Users should be empowered to customize button behavior without touching aem.js.

Changes

Decoration logic (scripts/scripts.js):

  • Opt-in only: plain links stay links
  • Bold → primary button (dark solid)
  • Italic → secondary button (outlined)
  • Bold+italic → accent button (blue solid, for CTAs)

Styles (styles/styles.css):

  • Three button variants with clear hierarchy
  • Modern inline-flex layout
  • Proper disabled states (aria-disabled for links, disabled for buttons)
  • focus-visible for keyboard navigation
  • Semantic button.button selector (opt-in for developers too)

Breaking Changes

Incompatible. Plain links in paragraphs no longer auto-convert to buttons. Authors must use bold or italic formatting to create buttons.

Migration: Add bold formatting to existing button links in content.

Coordination

⚠️ Requires tandem PR 199 in aem-lib to remove decorateButtons (v3.0.0 breaking change with MIGRATION.md).

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Feb 5, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Feb 5, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie
Copy link
Copy Markdown
Member Author

fkakatie commented Feb 5, 2026

Heads up, @sirugh.

Copy link
Copy Markdown
Contributor

@shsteimer shsteimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌭

fkakatie added a commit to adobe/aem-lib that referenced this pull request Feb 12, 2026
BREAKING CHANGE: The decorateButtons function has been removed. See MIGRATION.md for upgrade instructions.

Ref: adobe/aem-boilerplate#585
trieloff pushed a commit to adobe/aem-lib that referenced this pull request Feb 19, 2026
# [3.0.0](v2.10.6...v3.0.0) (2026-02-19)

### Documentation

* add migration guide for v3.0.0 ([f031893](f031893)), closes [adobe/aem-boilerplate#585](adobe/aem-boilerplate#585)

### BREAKING CHANGES

* The decorateButtons function has been removed. See MIGRATION.md for upgrade instructions.
@fkakatie fkakatie merged commit b403fc1 into main Feb 19, 2026
4 checks passed
@fkakatie fkakatie deleted the button-migration branch February 19, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants