Skip to content

feat(lib): update scripts/aem.js to aem.js@3.0.0#595

Merged
fkakatie merged 1 commit intomainfrom
update-lib-aem-major-3-0-0
Feb 19, 2026
Merged

feat(lib): update scripts/aem.js to aem.js@3.0.0#595
fkakatie merged 1 commit intomainfrom
update-lib-aem-major-3-0-0

Conversation

@trieloff
Copy link
Copy Markdown
Contributor

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Feb 19, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Feb 19, 2026

Page Scores Audits Google
📱 / Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI
🖥️ / Lighthouse returned error: NO_FCP. The page did not paint any content. Please ensure you keep the browser window in the foreground during the load and try again. (NO_FCP) PSI

@fkakatie fkakatie merged commit 50751a5 into main Feb 19, 2026
7 of 9 checks passed
@fkakatie fkakatie deleted the update-lib-aem-major-3-0-0 branch February 19, 2026 16:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the core aem.js library from an earlier version to v3.0.0, which includes breaking changes. The update removes the decorateButtons function and adds a guard clause to prevent re-decoration of icons.

Changes:

  • Removed the decorateButtons function (38 lines) that automatically decorated links as buttons
  • Added a guard clause to decorateIcon to prevent re-decoration of already-decorated icons
  • Removed decorateButtons from the module exports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

decorateBlock,
decorateBlocks,
decorateButtons,
decorateIcons,
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of decorateButtons from the exports will break the existing code in scripts/scripts.js, which imports and calls this function on lines 5 and 85. This PR is incomplete as it only updates aem.js but does not update the dependent scripts.js file.

To complete this migration to aem.js v3.0.0, you must also update scripts/scripts.js to:

  1. Remove decorateButtons from the import statement on line 5
  2. Remove the call to decorateButtons(main) on line 85

According to the aem.js v3.0.0 breaking changes, button decoration functionality has been removed from the core library.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants