feat(lib): update scripts/aem.js to aem.js@3.0.0#595
Conversation
Test URL: https://update-lib-aem-major-3-0-0--aem-boilerplate--adobe.aem.live/ BREAKING CHANGE: please check https://github.com/adobe/aem-lib/releases/tag/v3.0.0 for breaking changes
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates the core aem.js library from an earlier version to v3.0.0, which includes breaking changes. The update removes the decorateButtons function and adds a guard clause to prevent re-decoration of icons.
Changes:
- Removed the
decorateButtonsfunction (38 lines) that automatically decorated links as buttons - Added a guard clause to
decorateIconto prevent re-decoration of already-decorated icons - Removed
decorateButtonsfrom the module exports
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| decorateBlock, | ||
| decorateBlocks, | ||
| decorateButtons, | ||
| decorateIcons, |
There was a problem hiding this comment.
The removal of decorateButtons from the exports will break the existing code in scripts/scripts.js, which imports and calls this function on lines 5 and 85. This PR is incomplete as it only updates aem.js but does not update the dependent scripts.js file.
To complete this migration to aem.js v3.0.0, you must also update scripts/scripts.js to:
- Remove
decorateButtonsfrom the import statement on line 5 - Remove the call to
decorateButtons(main)on line 85
According to the aem.js v3.0.0 breaking changes, button decoration functionality has been removed from the core library.
Test URL: https://update-lib-aem-major-3-0-0--aem-boilerplate--adobe.aem.live/
BREAKING CHANGE: please check https://github.com/adobe/aem-lib/releases/tag/v3.0.0 for breaking changes