FORMS-18927 Added support for custom extensions using the edit dialogue by rajatofficial · Pull Request #1541 · adobe/aem-core-forms-components

rajatofficial · 2025-03-06T05:52:15Z

Allowed file types support new MIME types or extensions in AEM Forms File Attachment component.

adobe-bot · 2025-03-06T06:12:04Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-03-06T06:12:04Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-03-06T06:12:14Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-06T06:13:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-06T06:14:02Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta

please add a test collateral for this

rismehta · 2025-03-07T09:25:57Z

I have already fixed the flaky test, please re-sync with dev and add automation test case for the current change

adobe-bot · 2025-03-10T09:57:52Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-03-10T09:57:52Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-03-10T09:58:03Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-10T09:59:27Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-10T09:59:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-11T05:19:45Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-03-11T05:19:45Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-03-11T05:19:55Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-11T05:20:35Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-11T05:22:27Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov · 2025-03-13T09:49:03Z

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (6313288) to head (3598361).

Files with missing lines	Patch %	Lines
...nents/internal/models/v3/form/FileInputImplV3.java	50.00%	2 Missing and 1 partial ⚠️
...q/forms/core/components/models/form/FileInput.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #1541      +/-   ##
============================================
- Coverage     82.32%   82.22%   -0.10%     
- Complexity     1000     1002       +2     
============================================
  Files           108      108              
  Lines          2603     2611       +8     
  Branches        370      371       +1     
============================================
+ Hits           2143     2147       +4     
- Misses          272      275       +3     
- Partials        188      189       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

adobe-bot · 2025-03-13T10:03:01Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-03-13T10:03:01Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-03-13T10:03:11Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-03-13T10:04:00Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-03-13T10:04:01Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-04-25T08:13:39Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-04-25T11:09:51Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	96	96	75

adobe-bot · 2025-04-25T11:10:02Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-04-25T11:10:47Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-04-25T11:10:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-04-25T11:10:56Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot · 2025-04-25T11:11:49Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-04-25T12:15:16Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-04-25T12:15:28Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	96	96	75

adobe-bot · 2025-04-25T12:15:28Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot · 2025-04-25T12:15:38Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious

adobe-bot · 2025-04-25T12:16:11Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

…st cases

…sions

adobe-bot · 2025-05-07T05:05:47Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

rismehta requested changes Mar 7, 2025

View reviewed changes

github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 252a0a6 to 85644fa Compare March 10, 2025 09:36

github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 4cde36d to 8f6370c Compare March 13, 2025 09:41

rajatofficial force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch 2 times, most recently from de85449 to b0c4425 Compare April 1, 2025 05:12

github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from d8110d5 to 9d8ddba Compare April 25, 2025 07:26

rajatofficial force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 9d8ddba to 5795dc0 Compare April 25, 2025 07:26

rajatkhurana-adobe added 17 commits May 7, 2025 04:41

added support for custom extensions using the edit dialogue

1ffbe62

feat(FileExtensionSupport): add support for custom file extensions te…

dab954d

…st cases

Updated help description to support file extensions as well

74ac42b

added support for new extesnions in the file input with test cases

b26fe17

feat(FileExtensionSupport): add support for custom file extensions te…

dc78624

…st cases

Updated help description to support file extensions as well

832ed88

added support for new extesnions removed extra changes from other ver…

16a6a6a

…sions

feat(newExtensionsSupport): test cases fixed

69dfe31

added new support for extensions

81b75c7

hiding info icon as per extensions support

9d5a826

file extensions masking removed

7e93f33

Test cases for model added

db44ec5

test cases fixed

4e1285d

test cases fixed I

3618248

test cases fixed for extensions support in file input

55ad1a9

test cases fixed for extensions support in file input

5951ad8

File Type and file extensions descriptions added

793ac61

github-actions bot force-pushed the FORMS-18927-AllowNewMIMETypesAndExtensions branch from 920a278 to 793ac61 Compare May 7, 2025 04:41

Conversation

rajatofficial commented Mar 6, 2025

Uh oh!

adobe-bot commented Mar 6, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 6, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 6, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 6, 2025

Accessibility Violations Found

Uh oh!

rismehta left a comment

Choose a reason for hiding this comment

Uh oh!

rismehta commented Mar 7, 2025

Uh oh!

adobe-bot commented Mar 10, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 10, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 10, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 10, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 10, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 11, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 11, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 11, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 11, 2025

Accessibility Violations Found

Uh oh!

codecov bot commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adobe-bot commented Mar 13, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Mar 13, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Mar 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Mar 13, 2025

Accessibility Violations Found

Uh oh!

adobe-bot commented Apr 25, 2025

Lighthouse scores (desktop)

Uh oh!

adobe-bot commented Apr 25, 2025

Lighthouse scores (mobile)

Uh oh!

adobe-bot commented Apr 25, 2025

Accessibility Violations Found

codecov bot commented Mar 13, 2025 •

edited

Loading