feat(dialog): add fieldType hidden field to container v2 dialog#1843
Open
feat(dialog): add fieldType hidden field to container v2 dialog#1843
Conversation
github-actions
bot
force-pushed
the
rismehta/feat-container-fieldtype
branch
from
59b9b51 to
aeb409e
Compare
Accessibility Violations Found
|
3 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
3 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Adds a hidden select field for fieldType with value 'form' to the container v2 dialog, consistent with all other AF2 component dialogs. This exposes the container's fieldType via the Content API's componentDefinitions endpoint, enabling type validation of patches targeting form container properties. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
force-pushed
the
rismehta/feat-container-fieldtype
branch
from
785b38c to
2d1aff2
Compare
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fieldTypeselect field with valueformto the container v2_cq_dialog, consistent with all other AF2 component dialogs (textinput, numberinput, dropdown, etc.)fieldTypevia the Content API'scomponentDefinitionsendpoint, enabling pre-submission type validation of patches targeting form container propertiesTest plan
GET /adobe/pages/<pageId>/content-definitionreturnsfieldTypewithvalueType: stringandoptions: ["form"]for the container component🤖 Generated with Claude Code