FORMS-24462 : Support for Scribble Signature component in React Vanilla components#169
Merged
armaang1729 merged 8 commits intomainfrom Apr 2, 2026
Merged
FORMS-24462 : Support for Scribble Signature component in React Vanilla components#169armaang1729 merged 8 commits intomainfrom
armaang1729 merged 8 commits intomainfrom
Conversation
sakshi-arora1
left a comment
sakshi-arora1
left a comment
There was a problem hiding this comment.
PR Review: Scribble Signature Component
Overall this is a solid new component with good test coverage and proper BEM structure. Below are inline comments on issues I found — mostly around accessibility, performance, and correctness.
packages/react-vanilla-components/__tests__/components/Scribble.test.tsx
Show resolved
Hide resolved
added 5 commits
March 27, 2026 10:46
- Use typed placeholder and destructured dispatchChange (no any cast) - Sync signature from value via functional setState; only when value is string - Clear message timers on unmount and when dismissing messages manually - Track canvas strokes with canvasDrawnRef to skip full-pixel isCanvasEmpty scan - Add aria-level on dialog header; keyboard-accessible signed area (role=button) - Associate label with id-widget on signed container; avoid nested buttons Made-with: Cursor
Made-with: Cursor
rajatofficial
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Scribble Signature component in React Vanilla components
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: