Skip to content

FORMS-18734: Text content lacks 4.5:1 contrast ratio@sunnym @vavarshn #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CezarSTF wants to merge 1 commit into from
Closed

FORMS-18734: Text content lacks 4.5:1 contrast ratio@sunnym @vavarshn #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/site/_mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
&[data-cmp-valid=false]>&__label,
&[data-cmp-valid=false]>&__label-container>&__label {
font-weight: 500;
color: $error ;
color: $error-darker;
}
}

Expand Down Expand Up @@ -249,7 +249,7 @@
@mixin error-message {
&__errormessage {
display: none;
color: $error;
color: $error-darker;
Copy link
Copy Markdown
Contributor

@akshayvas akshayvas Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF There is an existing $dark-error token also being used in few states like hover.
Please check once if the appearance is fine, and if the contrast works fine for those states too.
cc: @vaibhav2601

Copy link
Copy Markdown
Collaborator Author

@CezarSTF CezarSTF Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshayvas because $dark-error is rgba(255,57,50,0.148), the contrast ratio will be 1.2:1.
I used a new variable (error-darker) to match the required contrast ratio (4.5:1)

font-size: $font-s;
font-weight: 500;
margin-bottom: $space-s;
Expand Down
1 change: 1 addition & 0 deletions src/site/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ $very-light-gray: #ccc;
$bg-gray: #eee;
$white: #fff;
$error: #eb3c36;
$error-darker: #b40000;
$light-error: rgba(235, 60, 54, 0.05);
$dark-error: rgba(255, 57, 50, 0.148);
$accent: rgb(21, 88, 212);
Expand Down