Skip to content

FORMS-18740: State of active component lacks 3 to 1 contrast ratio @sunnym @vavarshn #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefan-dragomir wants to merge 1 commit into from
Closed

FORMS-18740: State of active component lacks 3 to 1 contrast ratio @sunnym @vavarshn #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/site/_mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,11 @@
border-bottom: $border-light;
border-color: transparent;
border: none;
font-weight: normal;

&--active {
color: $accent;
color: $black;
Copy link
Copy Markdown
Contributor

@akshayvas akshayvas Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-dragomir instead of black, we should check if another shade of same color can be used to fix contrast. if not possible, then confirm with XD once

Copy link
Copy Markdown
Collaborator Author

@stefan-dragomir stefan-dragomir Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black was the designer's suggestion to make the tab color more striking since we can't change the tab's background color.
Also moving this to a PR raised from Main instead of Fork. #22

font-weight: 600;
}

&:last-child {
Expand Down
1 change: 1 addition & 0 deletions src/site/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ $secondary: rgb(22, 22, 22);
$very-light-gray: #ccc;
$bg-gray: #eee;
$white: #fff;
$black: #000;
$error: #eb3c36;
$light-error: rgba(235, 60, 54, 0.05);
$dark-error: rgba(255, 57, 50, 0.148);
Expand Down