Skip to content

FORMS-18740: State of active component lacks 3 to 1 contrast ratio @sunnym @vavarshn #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaibhav2601 merged 5 commits into from
Sep 18, 2025
Merged

FORMS-18740: State of active component lacks 3 to 1 contrast ratio @sunnym @vavarshn #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b55dc65
FORMS-18740: State of active component lacks 3 to 1 contrast ratio @s…
Jul 24, 2025
6b8d829
FORMS-18740: Updating tabsontop with the same color scheme
Aug 12, 2025
6818f47
FORMS-18740: New design feedback implemented
Aug 28, 2025
2340e61
FORMS-18740: Removing active tab background
Sep 9, 2025
0b5161b
FORMS-18740: Correcting flex-end and border-bottom
Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/site/_mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@
box-sizing: border-box;
flex: 1;
display: flex;
align-items: center;
font-size: $font-m;
border-radius: $button-radius;
border-bottom-width: 2px;
Expand All @@ -468,7 +467,7 @@
border: none;

&--active {
color: $accent;
color: $black;
Copy link
Copy Markdown
Contributor

@akshayvas akshayvas Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-dragomir It is ok to change to black from accent color of theme, if design team has recommended, as you mentioned in JIRA. Please check, are tabs(tabsontop and vertical) also facing same issue of contrast? They use same colors. Or you can also check with design team, if we should make both follow similar color scheme, as is the case now

Copy link
Copy Markdown

@vaibhav2601 vaibhav2601 Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-dragomir

Please add the screenshots and mention the discussion which you had with the designer.

Copy link
Copy Markdown
Collaborator Author

@stefan-dragomir stefan-dragomir Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion archive link added in PR comment and Jira.

}

&:last-child {
Expand Down Expand Up @@ -500,7 +499,6 @@
text-align: center;
font-size: $font-s;
}

}

@mixin default-tab {
Expand All @@ -511,7 +509,8 @@
font-size: $font-m;
align-self: flex-start;
display: flex;
align-items: center;
flex-flow: wrap;
align-items: flex-end !important;
font-weight: 600;
border-radius: $button-radius;
border-width: 2px;
Expand All @@ -525,24 +524,29 @@
}

&--active {
color: $accent;
color: $black;
border-color: transparent;
display: flex;
align-items: center;

background-color: rgba($color: #000, $alpha: .05);
// background-color: rgba($color: #000, $alpha: .05);
// box-shadow: 0 15px 10px -15px rgba(42, 69, 152, 0.345);
&:hover {
color: $accent;
}
}

&--active::after {
content: '—';
display: none;
color: $accent;
&::after {
content: "";
display: block;
width: 100%;
}

&--active::after {
content: "";
display: block;
width: 100%;
border-bottom: 2px solid $black;
}
}

@mixin tab-list {
Expand Down Expand Up @@ -583,7 +587,7 @@
}
&--active {
background-color: rgba($color: #000, $alpha: .05);
color: $secondary;
color: $black
}
}

Expand Down
1 change: 1 addition & 0 deletions src/site/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ $secondary: rgb(22, 22, 22);
$very-light-gray: #ccc;
$bg-gray: #eee;
$white: #fff;
$black: #000;
$error: #b40000;
$light-error: rgba(235, 60, 54, 0.05);
$dark-error: rgba(255, 57, 50, 0.148);
Expand Down
Loading