Skip to content

FORMS-18743: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefan-dragomir wants to merge 1 commit into from
Closed

FORMS-18743: Active user interface component lacks 3 to 1 contrast ratio @sunnym @vavarshn #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/radiobutton/_radiobutton.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
appearance: none;
margin: 0;
border-radius: 1rem;
border: 1px solid $light-gray;
Copy link
Copy Markdown
Contributor

@akshayvas akshayvas Apr 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-dragomir If we are changing border color for radio button, should it not be same for checkbox as well ?
Or rather for all input fields. Currently also, #ddd color is common for all input fields.
cc: @vaibhav2601

Copy link
Copy Markdown
Contributor Author

@stefan-dragomir stefan-dragomir Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in #40

}

input[type='radio']:checked {
Expand Down
2 changes: 1 addition & 1 deletion src/site/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ $error: #c61d17;
$light-error: rgba(235,60,54,0.05);
$white: #fff;
$gray: rgb(109, 109, 109);
$light-gray: #969696;
$light-gray: #8E8E8E;
$very-light-gray: #ddd;
$disabled-color: $background-color;

Expand Down