ASSETS-62882 Update test to allow and match dynamic IDs#229
Closed
cmrockwell wants to merge 1 commit intoadobe:aem-cloudfrom
Closed
ASSETS-62882 Update test to allow and match dynamic IDs#229cmrockwell wants to merge 1 commit intoadobe:aem-cloudfrom
cmrockwell wants to merge 1 commit intoadobe:aem-cloudfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update asset upload Cypress test for dynamic rename input IDs
https://jira.corp.adobe.com/browse/ASSETS-62882
Description
The asset upload rename input in
fileupload.jsnow appends index to create unique IDs (e.g.dam-asset-upload-rename-input-{idx}) if multiple files are uploaded. The first will be static IDdam-asset-upload-rename-input.This PR updates the Cypress test in
assets.cy.jsto target the rename input with an attribute selector that works for both the old static ID and the new unique IDs.Related Issue
ASSETS-62882
Motivation and Context
The upload UI now assigns a unique ID per rename input to avoid ID collisions when multiple uploads or dialogs are in use. The test previously used
input#dam-asset-upload-rename-input, which fails when the ID is dynamic. Usinginput[id^="dam-asset-upload-rename-input"]keeps the test passing for both the legacy static ID and the new unique IDs, so the test stays compatible with current and older AEM Assets behavior.How Has This Been Tested?
/content/dam.completeUpload.jsonwhich will only be requested when using Asset Binary Cloud StorageScreenshots (if appropriate):
Types of changes
Checklist: