Skip to content

fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link#824

Merged
shazron merged 9 commits intomasterfrom
story/ACNA-3397
Jan 21, 2025
Merged

fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link#824
shazron merged 9 commits intomasterfrom
story/ACNA-3397

Conversation

@shazron
Copy link
Copy Markdown
Member

@shazron shazron commented Dec 10, 2024

fixes #823

Pre-requisite

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8f968ab) to head (e01538c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #824   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        58    +1     
  Lines         3343      3351    +8     
  Branches       649       648    -1     
=========================================
+ Hits          3343      3351    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couple doc nits

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Dec 12, 2024

Pre-requisites need to be fulfilled before this is merged. https://jira.corp.adobe.com/browse/ACNA-3418

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Jan 7, 2025

the checks are failing because the dependent PRs have been merged (and the branches deleted), and this is awaiting the module release and updating of package.json

@shazron
Copy link
Copy Markdown
Member Author

shazron commented Jan 7, 2025

temporarily updated the PR deps to point to the master branch so checks will pass.

@shazron shazron merged commit 7c44a98 into master Jan 21, 2025
@shazron shazron deleted the story/ACNA-3397 branch January 21, 2025 08:57
purplecabbage pushed a commit that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web action does not have web in the url, resulting in an invalid link

3 participants