fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link#824
Merged
fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link#824
Conversation
…n an invalid link
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 58 +1
Lines 3343 3351 +8
Branches 649 648 -1
=========================================
+ Hits 3343 3351 +8 ☔ View full report in Codecov by Sentry. |
moritzraho
approved these changes
Dec 11, 2024
MichaelGoberling
approved these changes
Dec 11, 2024
Contributor
MichaelGoberling
left a comment
There was a problem hiding this comment.
LGTM! Couple doc nits
Member
Author
|
Pre-requisites need to be fulfilled before this is merged. https://jira.corp.adobe.com/browse/ACNA-3418 |
Member
Author
|
the checks are failing because the dependent PRs have been merged (and the branches deleted), and this is awaiting the module release and updating of package.json |
Member
Author
|
temporarily updated the PR deps to point to the master branch so checks will pass. |
purplecabbage
pushed a commit
that referenced
this pull request
Nov 10, 2025
…n an invalid link (#824)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #823
Pre-requisite
Blocked by: needs fix: ACNA-3397 - web action does not have web in the url, resulting in an invalid link aio-lib-runtime#197 merged and releasednpm i @adobe/aio-lib-runtime@latestBlocked by: fix: ACNA-3397 - excludeweb-exportandraw-httpproperties in action, allowwebproperty to be boolean aio-cli-lib-app-config#38 merged and releasednpm i @adobe/aio-cli-lib-app-config@latestHow Has This Been Tested?
webin the url, resulting in an invalid link #823 with a locally linked app plugin and the above runtime lib PR codeTypes of changes
Checklist: