Skip to content

Comments

Temp Fix: Fallback to npm install when npm ci fails#900

Merged
MichaelGoberling merged 1 commit intomasterfrom
fix-npm-install-temp
Feb 5, 2026
Merged

Temp Fix: Fallback to npm install when npm ci fails#900
MichaelGoberling merged 1 commit intomasterfrom
fix-npm-install-temp

Conversation

@riddhi2910
Copy link
Contributor

@riddhi2910 riddhi2910 commented Feb 5, 2026

Description

Adds fallback logic in aio app install to handle npm ci failures when the lockfile is out of sync with package.json. When npm ci fails (e.g., lockfile mismatch), the command falls back to npm install instead of failing.

Related Issue

https://jira.corp.adobe.com/browse/ACNA-4323

How Has This Been Tested?

  1. npm test (after adding the unit test)
  2. aio app install color-web-app-excshell-out-of-sync-lock.zip

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MichaelGoberling MichaelGoberling merged commit e3cfbbf into master Feb 5, 2026
11 checks passed
@MichaelGoberling MichaelGoberling deleted the fix-npm-install-temp branch February 5, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants