Skip to content

CEXT-6117: Fix empty worker process causing aio app build to fail#416

Merged
iivvaannxx merged 11 commits intomainfrom
CEXT-6117-missed-review
Apr 30, 2026
Merged

CEXT-6117: Fix empty worker process causing aio app build to fail#416
iivvaannxx merged 11 commits intomainfrom
CEXT-6117-missed-review

Conversation

@iivvaannxx
Copy link
Copy Markdown
Collaborator

@iivvaannxx iivvaannxx commented Apr 27, 2026

Description

This PR does the following:

  • Fix an issue where an empty workerProcess: [] was generated for Admin UI and caused aio app build to fail.
  • Adds some test cases for iframe Admin UI SDK
  • Adds a TODO note on some code that can be cleaned up after an upstream issue in valibot is solved

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2026

⚠️ No Changeset found

Latest commit: b65ab43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added without-changeset The PR does not contain a Changeset file pkg: aio-commerce-lib-app Includes changes in `packages/aio-commerce-lib-app` labels Apr 27, 2026
Comment thread packages/aio-commerce-lib-app/source/config/schema/admin-ui-sdk.ts Outdated
Comment thread packages/aio-commerce-lib-app/source/config/schema/admin-ui-sdk.ts Outdated
@iivvaannxx iivvaannxx force-pushed the CEXT-6117-missed-review branch from 71bcb82 to bf137b8 Compare April 29, 2026 08:20
@iivvaannxx iivvaannxx marked this pull request as ready for review April 29, 2026 08:23
Copy link
Copy Markdown
Member

@obarcelonap obarcelonap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no strong opinion on the import vs self contained discussion

@iivvaannxx iivvaannxx force-pushed the CEXT-6117-missed-review branch from bf137b8 to c4e4828 Compare April 29, 2026 14:59
@iivvaannxx
Copy link
Copy Markdown
Collaborator Author

/snapshot

@github-actions
Copy link
Copy Markdown
Contributor

No new changesets found in this PR. Run pnpm changeset add before requesting a snapshot.

@github-actions github-actions Bot added the private-pkg: scripting-utils Includes changes to `packages-private/scripting-utils` label Apr 29, 2026
@iivvaannxx iivvaannxx changed the title CEXT-6117: Missed suggestions CEXT-6117: Fix empty worker process causing aio app build to fail Apr 30, 2026
@iivvaannxx iivvaannxx merged commit 2b838c7 into main Apr 30, 2026
6 checks passed
@iivvaannxx iivvaannxx deleted the CEXT-6117-missed-review branch April 30, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: aio-commerce-lib-app Includes changes in `packages/aio-commerce-lib-app` private-pkg: scripting-utils Includes changes to `packages-private/scripting-utils` without-changeset The PR does not contain a Changeset file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants