Skip to content

Comments

fix: v1 should be commonJS#10

Merged
moritzraho merged 3 commits intomainfrom
fix/cjs
Feb 17, 2026
Merged

fix: v1 should be commonJS#10
moritzraho merged 3 commits intomainfrom
fix/cjs

Conversation

@moritzraho
Copy link
Member

@moritzraho moritzraho commented Feb 13, 2026

Description

Our aio-sdk-core, aio-sdk and tooling is still relying on commonJS, moving to ESM should be undertaken as a bigger coordinated change. So V1, as documented in the README, should be CommonJS

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moritzraho moritzraho marked this pull request as ready for review February 13, 2026 09:10
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@moritzraho moritzraho merged commit d623981 into main Feb 17, 2026
11 checks passed
@moritzraho moritzraho deleted the fix/cjs branch February 17, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants