feat: support include-ims-credentials annotation#224
Merged
moritzraho merged 4 commits intomasterfrom Feb 20, 2026
Merged
Conversation
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
|
10 tasks
10 tasks
93f755b to
2dae593
Compare
shazron
approved these changes
Feb 19, 2026
pru55e11
reviewed
Feb 19, 2026
pru55e11
approved these changes
Feb 19, 2026
| * @returns {object|undefined} the inputs or undefined with a warning | ||
| */ | ||
| function getIncludeIMSCredentialsAnnotationInputs (thisAction, imsAuthObject) { | ||
| const env = getCliEnv() || DEFAULT_ENV |
Member
There was a problem hiding this comment.
Did you want to merge properties?
const env = Object.assign({}, DEFAULT_ENV, getCliEnv())
| */ | ||
| function loadIMSCredentialsFromEnv () { | ||
| // constants | ||
| const IMS_OAUTH_S2S_ENV_KEY = 'IMS_OAUTH_S2S' |
Member
There was a problem hiding this comment.
small thing, I know this is a constant and typically we use SCREAMING_SNAKE, but the fact that it is declared like a local var means we can treat it differently. I think const ims_oauth_s2s_env_key would be clearer once we get to
const imsAuthObject = {
client_id: process.env[`${ims_oauth_s2s_env_key}_CLIENT_ID`]
and case is somewhat fluid when we get to getIncludeIMSCredentialsAnnotationInputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DRAFT
Depends on a release of adobe/aio-cli-plugin-app#899
Propose a new
include-ims-credentialsannotation at the action level. The annotation depends on a newIMS_OAUTH_S2Senvironment variable.Here is an example:
Rewrites to
Note: the
__imsprefix was chosen to align with__owas inparams.__ow_headersRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: