-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add adobe analytics tracking id to redocly api block #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
melissag-ensemble
wants to merge
2
commits into
main
Choose a base branch
from
devsite-1307-try-it-analytics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to think about how we are attaching the specific link tracking. Not sure what exactly fires when you hit the try it button but I'm going to assume that all try it buttons will get captured with
Redocly-Containerid. We'd ideally like to have the link tracking unique to every try it button. I think in this case we can replacedaa-llwithdaa-lhwhich sets just the section for the analytics tracking. And then re-take a look on how we can attach the call to the try it button again...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @timkim, I've replaced the attribute with
daa-lhand tested with https://developer-stage.adobe.com/redocly-test/api-full/. I think we can differentiate between the different operations and buttons clicked with the three values:pageUrl = https://developer-stage.adobe.com/redocly-test/api-full/#operation/uploadFile
Activity Map Link = d1d1d1d1d3d1d1d3d3d1d2d1d1B1-Try it
Link Name = Redocly-Container
pageUrl = https://developer-stage.adobe.com/redocly-test/api-full/#operation/uploadFile
Activity Map Link = d1d1d1d1d3d1d1d3d3d1d2d1d4B1-Send
Link Name = Redocly-Container
pageUrl = https://developer-stage.adobe.com/redocly-test/api-full/#operation/addPet
Activity Map Link = d1d1d1d1d3d1d1d3d4d1d2d1d1B1-Try it
Link Name = Redocly-Container
pageUrl = https://developer-stage.adobe.com/redocly-test/api-full/#operation/addPet
Activity Map Link = d1d1d1d1d3d1d1d3d4d1d2d1d4B1-Send
Link Name = Redocly-Container
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timkim I'm assuming I'll have to rewrite this once we migrate from Adobe analytics to CJA analytics.
(Hoping I'm able to hook up redocly's TryItOpen and TryItSent events using step 4 in the wiki https://wiki.corp.adobe.com/display/marketingtech/Adobe+Experience+Platform+Integration+Guide. Assuming we don't have that loading issue with gatsby and are able to make a command and trust that it dequeues when _satellite.track is ready)