Skip to content

feat: add node-fetch-v3 support#54

Open
solaris007 wants to merge 1 commit intoadobe:masterfrom
solaris007:node-fetch-v3-support
Open

feat: add node-fetch-v3 support#54
solaris007 wants to merge 1 commit intoadobe:masterfrom
solaris007:node-fetch-v3-support

Conversation

@solaris007
Copy link
Copy Markdown
Member

@solaris007 solaris007 commented Sep 1, 2021

Description

node-fetch v3 has been released. This PR serves for starting the discussion of updating node-fetch-retry to allow use of v3, which is ESM only. A full conversion of node-fetch-retry to ESM is not necessary when using async import.

Minimum node version required would be 12.20

https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md

Fixes # (issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Dependency update with code changes (no functional impact)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jdelbick
Copy link
Copy Markdown
Contributor

jdelbick commented Sep 8, 2021

please fix the failing unit tests for node 10.16, 10.19 & 12.16

@alexkli alexkli added the contribution PR from an external contributor label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants