Conversation
|
The ITs & dependent tests are failing. Likely unrelated. |
|
Ok, I've retried the ITs a couple times now. |
|
It's hard to parse the circleci output, but for the For the @pheenomenon Are we ok to merge despite the errors? |
|
I have created a jira to look more into it.. My initial analysis is, it's unrelated, as other open source CI had the same issue in the CI adobe/asset-compute-events-client#36. |
|
@pheenomenon ok, thanks for looking at it. I'm planning on merging it as a breaking change, so it'll update the major version number of the library. Consumers will need to explicitly update the version, so if it ends up breaking anything it should be pretty easy to just revert while we figure things out. I'll merge it for now, and we can revisit if there are issues. I did run all the unit tests and e2e tests locally, and they all passed. So hopefully risk is low. |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Updates the library's
es2015build process so that it useswebpackinstead ofbabeldirectly. Introduced a basic webpack configuration that uses polyfills for various node.js-only modules required by the library.Also updates various dependencies to more secure versions, and changes the CI so that it runs tests on non-deprecated versions of node.js.
Note that I'll be releasing this as a breaking change, since the supported versions of node.js have changed, and because the output in the
es2015build directory has changed.Fixes #157
Types of changes
Checklist: