Skip to content

feat(image): Pass crossOrigin prop in to Image #8532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

feat(image): Pass crossOrigin prop in to Image #8532

merged 1 commit into from
Jul 14, 2025

Conversation

mofojed
Copy link
Contributor

@mofojed mofojed commented Jul 11, 2025

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • Check the Image component in Storybook, ensure it's still loading
  • Ensure the unit tests pass

🧢 Your Project:

Deephaven

@mofojed mofojed closed this Jul 11, 2025
@mofojed mofojed reopened this Jul 11, 2025
@mofojed
feat(image): Pass crossOrigin prop in
a38f304 
- Allow setting the crossOrigin prop on the Image component
- Added unit tests
- Fixes adobe#8531
@mofojed mofojed force-pushed the image-cross-origin branch from 258cb2c to a38f304 Compare July 11, 2025 21:20
reidbarber
reidbarber approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the tests!

snowystinger
snowystinger approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@snowystinger snowystinger added this pull request to the merge queue Jul 14, 2025
Merged via the queue into adobe:main with commit fe5e1b6 Jul 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting crossOrigin prop on Image component
3 participants
@mofojed @snowystinger @reidbarber