Skip to content

Conversation

vintagefuture
Copy link

Without these dependencies yarn storybook won't launch out of the box

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
    Couldn't find an open issue
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
    Non applicable
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
    Non applicable
  • Looked at the Accessibility Practices for this feature - Aria Practices
    Non applicable

📝 Test Instructions:

  • Clone the repo
  • Jump to presets/docs folder
  • Open in vscode or other editor
  • run yarn install
  • run yarn storybook
  • storybook build crashes:
    SB_BUILDER-WEBPACK5_0003 (WebpackCompilationError): There were problems when compiling your code with Webpack
  • now run yarn add -D @babel/preset-typescript @babel/preset-env
  • yarn storybook executes successfully and you're redirected to browser

without these dependencies yarn storybook won't launch out of the box
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think yarn got a little more strict recently

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind signing the CLA so we can get this in? Thanks!
https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants