feat: Add support for disclosure animation #8867
Merged
+97
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7528
Adds
--disclosure-panel-width
and--disclosure-panel-height
CSS variables, which are set to thescrollWidth
andscrollHeight
of the panel when expanding and collapsing. If any animations are triggered, then we wait to set thehidden
attribute until they complete.In the future this may be possible in native CSS with the
interpolate-size: allow-keywords
property (currently only in Chrome) along withtransition-behavior: allow-discrete
, which allows usingheight: auto
anddisplay: none
directly. In the meantime, this is a pretty simple polyfill that must be done within the hooks to ensure correct timing.