Skip to content

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Sep 17, 2025

Found in testing

Opted not to implement the entirety of https://unicode.org/reports/tr35/#unicode-locale-identifier
This particular change for the first day of the week fallback is only needed for FF and node right now.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

unit test should cover it, but there is a story in RAC Calendar which sets a numbering system beyond the first day of the week via controls

🧢 Your Project:

@rspbot
Copy link

rspbot commented Sep 17, 2025

@rspbot
Copy link

rspbot commented Sep 17, 2025

LFDanLu
LFDanLu previously approved these changes Sep 17, 2025
yihuiliao
yihuiliao previously approved these changes Sep 17, 2025
@snowystinger snowystinger dismissed stale reviews from yihuiliao and LFDanLu via 6de8eee September 17, 2025 22:30
@rspbot
Copy link

rspbot commented Sep 17, 2025

@snowystinger snowystinger added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit 6e467f8 Sep 17, 2025
32 checks passed
@snowystinger snowystinger deleted the fix-week-start-extension-parsing branch September 17, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants