-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: add icons search to search menu #9114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a vertical divider would be nice because otherwise it's a little weird. So something to indicate some separation would be helpful.
Have we thought about adding something like a toast or tooltip to indicate that you've copied the import when you click on the icon? Otherwise I feel like it's unclear what happens when you select an icon
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
@yihuiliao I agree, but also
I'll try adding something custom that's somewhere in between. |
|
I think the current thickness is fine, it's made a little more obvious by the additional padding around it. You can compare to the S1 Toolbar we have, because that's what this appears to be now |
|
Build successful! 🎉 |
| import {ComponentCardView} from './ComponentCardView'; | ||
| import {getLibraryFromPage, getLibraryFromUrl} from './library'; | ||
| import {iconAliases} from './iconAliases.js'; | ||
| import {iconList, IconSearchSkeleton} from './IconSearchView'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to move IconSearchSkeleton into a separate file otherwise the lazy import below won't do anything (it already got bundled in synchronously).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix in a follow-up


Adds an icons tag to the search menu where you can search icons and copy the imports (same as on the Icons page).
Also adds skeleton loading placeholders as the suspense fallback.
We may want to add vertical divider before the Icons tag in the menu to indicate that icons won't show up in the "All" search, open to feedback on this.
✅ Pull Request Checklist:
📝 Test Instructions:
Open the search menu, select the Icons tag, and begin searching: https://reactspectrum.blob.core.windows.net/reactspectrum/dff65bb6d444e26b0914dd4f90c440419d2978e7/s2-docs/index.html
🧢 Your Project: