Don't waste a number formatter #9128
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plesiecki
changed the title
snowystinger
reviewed
Nov 2, 2025
| let formatter = useNumberFormatter(formatOptions); | ||
|
|
||
| if (!isIndeterminate && !valueLabel) { | ||
| let formatter = useNumberFormatter(formatOptions); |
There was a problem hiding this comment.
This unfortunately breaks the rules of hooks. However, within useNumberFormatter we do cache them, so over the lifetime of an app, the expense should become less.
There was a problem hiding this comment.
Good point about the rules of hooks. Whether cached or not, it's still suboptimal and can block the main thread unnecessarily.
There was a problem hiding this comment.
are you running into an issue with it in your application? or is this hypothetical?
there are ways to write this so that the rules of hooks aren't broken, but I'd like to know more information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9127
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: