-
Notifications
You must be signed in to change notification settings - Fork 207
feat(accordion): remove modifiers; simplify selectors #4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spectrum-two
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 902d021 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Branch previewPR #4249 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4249/index.html. |
File metricsSummaryTotal size: 1.44 MB*
accordion
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
b3aeb55
to
81bc3a8
Compare
81bc3a8
to
902d021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not see any regressions in accordion with these changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this and I'm excited to try it out!
"--mod-accordion-item-width", | ||
"--mod-accordion-top-to-disclosure-indicator" | ||
], | ||
"modifiers": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 bye!
Description
This update removes
--mod-accordion-*
custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.--mod-accordion-*
custom property hooks..spectrum-Accordion--compact
,.spectrum-Accordion--spacious
,.spectrum-Accordion--quiet
,.is-open
,.is-disabled
) unchanged.--mod-accordion-*
override layer.Breaking change: the
--mod-accordion-*
override layer is removed. Consumers should set--spectrum-accordion-*
variables directly where customization is needed.Motivation and context
Related issue(s)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Accordion interactions
Densities and sizes
compact
,regular
,spacious
acrossS/M/L/XL
.Quiet and no inline padding
.spectrum-Accordion--quiet
and.spectrum-Accordion--noInlinePadding
.Disabled items
.is-disabled
to an item.--spectrum-disabled-content-color
to be used.Open state behavior
Device review