Skip to content

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Oct 7, 2025

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: c6b6abc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rajdeepc Rajdeepc added the WIP label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5790

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@Rajdeepc Rajdeepc changed the title [DRAFT]: fix(overlay): handles the pointerdown event to initiate a potential l… [DRAFT]: fix(overlay): handles the pointerdown event to initiate a potential long press Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Tachometer results

Currently, no packages are changed by this PR...

@Rajdeepc Rajdeepc changed the title [DRAFT]: fix(overlay): handles the pointerdown event to initiate a potential long press [DRAFT]: fix(overlay): Longpress interaction now enables all buttons after overlay opens Oct 7, 2025
@coveralls
Copy link
Collaborator

coveralls commented Oct 7, 2025

Pull Request Test Coverage Report for Build 18325424308

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 41 of 42 (97.62%) changed or added relevant lines in 1 file are covered.
  • 70 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 97.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/overlay/src/LongpressController.ts 41 42 97.62%
Files with Coverage Reduction New Missed Lines %
packages/button/src/ButtonBase.ts 2 99.04%
packages/combobox/src/Combobox.ts 8 98.27%
packages/overlay/src/LongpressController.ts 24 89.45%
packages/picker/src/Picker.ts 36 96.48%
Totals Coverage Status
Change from base Build 18198485546: 0.04%
Covered Lines: 34083
Relevant Lines: 34622

💛 - Coveralls

@Rajdeepc Rajdeepc changed the title [DRAFT]: fix(overlay): Longpress interaction now enables all buttons after overlay opens [Experiment]: fix(overlay): Longpress interaction now enables all buttons after overlay opens Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants