Skip to content

[Max2025][Firefly] second CTA support for Samsung S8 #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robert-bogos wants to merge 4 commits into from
Closed

[Max2025][Firefly] second CTA support for Samsung S8 #807

robert-bogos wants to merge 4 commits into from

Conversation

@robert-bogos
Copy link
Collaborator

@robert-bogos robert-bogos commented Oct 27, 2025 •
edited
Loading

Description:
This PR adds second CTA support for Samsung Galaxy S8

Resolves: MWPW-182813

Test URLs:
Before: https://stage--cc--adobecom.aem.live/products/firefly
After: https://mwpw-182813-cta-support--cc--adobecom.aem.live/products/firefly

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 27, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Oct 27, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@nkthakur48
Copy link
Collaborator

nkthakur48 commented Oct 28, 2025

Hi @robert-bogos, now that the content is published, could you please check the live URL for your fix and update that in the description? It seems like https://mwpw-182813-cta-support--cc--adobecom.aem.live/products/firefly is not loading any CSS files.
Screenshot 2025-10-28 at 6 51 46 PM

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Oct 28, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

2 similar comments
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Oct 29, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Oct 30, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@spadmasa spadmasa self-assigned this Oct 31, 2025
@spadmasa
Copy link
Collaborator

spadmasa commented Oct 31, 2025

Hi @robert-bogos can you please share the url for the fix to verify , this url https://mwpw-182813-cta-support--cc--adobecom.aem.live/products/firefly loading has css issue

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 3, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 4, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-182813-cta-support November 4, 2025 17:09 Inactive
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 5, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 6, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@robert-bogos
Copy link
Collaborator Author

robert-bogos commented Nov 6, 2025

Not quite obvious why the css is not loading, definitely not because of the code change. I'm currently looking into it

@aem-code-sync
Copy link

aem-code-sync bot commented Nov 6, 2025 •
edited
Loading

Page Scores Audits Google
📱 /products/firefly PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /products/firefly PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 10, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 11, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-182813-cta-support November 11, 2025 08:43 Inactive
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 12, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 13, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 17, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 18, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 19, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

3 similar comments
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 20, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 24, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 25, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support on Samsung S8 due to failing checks

@robert-bogos robert-bogos changed the title [Max2025][Firefly] second CTA support on Samsung S8 [Max2025][Firefly] second CTA support for Samsung S8 Nov 25, 2025
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 25, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support for Samsung S8 due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link

milo-pr-merge-cc bot commented Nov 26, 2025

Skipped merging 807: [Max2025][Firefly] second CTA support for Samsung S8 due to failing checks

@robert-bogos
Copy link
Collaborator Author

robert-bogos commented Nov 27, 2025 •
edited
Loading

Opened a new PR for this, where the CSS loading issue is not present anymore on the test page
#835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drashti1712 drashti1712 drashti1712 approved these changes

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@nkthakur48 nkthakur48 Awaiting requested review from nkthakur48

@JingleH JingleH Awaiting requested review from JingleH

Assignees

@spadmasa spadmasa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robert-bogos @nkthakur48 @spadmasa @drashti1712 @suhjainadobe