Added Giffin Dockerfile and instruction#11
Open
yueyaog wants to merge 2 commits intoadoebley:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @adoebley!
I have been testing and using Griffin for a couple of weeks and I found it very useful. I noticed that there is no official Docker support for Griffin, so I decided to create a Docker image for it. I hope the docker container I created could streamline the setup process for Griffin and enhance the user experience by encapsulating all dependencies and required configurations. It has been super useful to me in Griffin WDL development.
I have tested the Dockerfile and confirmed that it works as expected. The Dockerfile is based on the latest version of Griffin (v0.2.0) and includes all the necessary dependencies to run GC correction and nucleosome. I have created a
DockerImage/README.mdwith more detailed instructions. I would be happy to answer any questions or make any changes you might need. Let me know if there's anything else I can do to help.