Skip to content

Conversation

@valch
Copy link

@valch valch commented Jun 16, 2013

I hope the changes are functional! I would really appreciate your feedback! Thanks

Innovation13 added 5 commits June 12, 2013 16:12
I added DELETE_DIALOG=5 so it can reach the message of deleting account, and proceed according to the action(Yes/No) that the user selected.
 <string name="confirm_delete_dialog">Are you sure you want to delete your Account? Once deleted the account is gone forever.</string>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unnecessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't change anything in AndroidManifest.xml. I added it to my changes by mistake.

@appatalks
Copy link

I am keeping a keen eye on this one. It's close. I've noticed with the other options such as copy pass, Id and launch URL from context menu, the "getAccount(info.targetView)" is used to get the account in question. I'm trying to incorporate this into the code for the delete account. Though I am not sure this is even the right route or action to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants