Changed -Ofast to -O3 as -Ofast breaks larger models (>4B)#4
Open
andsam wants to merge 1 commit intoadriancable:mainfrom
Open
Changed -Ofast to -O3 as -Ofast breaks larger models (>4B)#4andsam wants to merge 1 commit intoadriancable:mainfrom
andsam wants to merge 1 commit intoadriancable:mainfrom
Conversation
Changed compilation parameter -Ofast to -O3 for openmp, win64, gnu and gnuopenmp as -Ofast seems not to work properly when using larger models like Qwen3-8B or 32B (the code eventually starts producing just !-signs or nothing due to nans in computation). Bug and fix confirmed using openmp on both WSL2/Ubuntu and native RHEL8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed compilation parameter -Ofast to -O3 for openmp, win64, gnu and gnuopenmp as -Ofast seems not to work properly when using larger models like Qwen3-8B or 32B (the code eventually starts producing just !-signs or nothing due to nans in computation).
Bug and fix confirmed using openmp on both WSL2/Ubuntu and native RHEL8.