Bug fix callJsMethod: Encode/decode JSON when passing data between languages#82
Open
gabrc52 wants to merge 1 commit intoadrianflutur:mainfrom
Open
Bug fix callJsMethod: Encode/decode JSON when passing data between languages#82gabrc52 wants to merge 1 commit intoadrianflutur:mainfrom
callJsMethod: Encode/decode JSON when passing data between languages#82gabrc52 wants to merge 1 commit intoadrianflutur:mainfrom
Conversation
Author
|
This is a breaking change on Android when non-Strings are returned from JS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
This should also allow passing maps, lists, ints, and doubles between languages but only on Android.
On iOS, it's possible to pass them as parameters to JS functions. But returning lists and maps from JS to Dart will return odd strings generated by Swift/ObjC. I decided to keep the old (but not buggy with strings anymore) behavior here, because type information is lost (i.e. it doesn't distinguish between a 42 and a '42'). So something further should be done, like statically allowing only Strings or doing manual parsing.
https://pub.dev/documentation/webview_flutter/latest/webview_flutter/WebViewController/evaluateJavascript.html: