Fixes #168 (running title in subtitle)#169
Merged
seasidesparrow merged 4 commits intoadsabs:mainfrom Apr 16, 2025
Merged
Conversation
Member
seasidesparrow
commented
Apr 16, 2025
seasidesparrow
commented
modified: adsingestp/parsers/jats.py new file: tests/stubdata/input/jats_springer_running_title_in_subtitle.xml new file: tests/stubdata/output/jats_springer_running_title_in_subtitle.json modified: tests/test_jats.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 91.44% 91.45%
=======================================
Files 27 27
Lines 3192 3193 +1
=======================================
+ Hits 2919 2920 +1
Misses 273 273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mugdhapolimera
approved these changes
Apr 16, 2025
Contributor
mugdhapolimera
left a comment
mugdhapolimera
left a comment
There was a problem hiding this comment.
So simple and easy! Looks good. Merge at your convenience!
modified: .pre-commit-config.yaml
modified: .github/workflows/ci.yml modified: .pre-commit-config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.