Merged
Conversation
modified: adsingestp/parsers/datacite.py
modified: adsingestp/parsers/datacite.py new file: tests/stubdata/input/datacite-metadata-sample-v2.0.xml new file: tests/stubdata/input/datacite-ornldaac-kernel2.2-0010.xml new file: tests/stubdata/output/datacite-metadata-sample-v2.0.json new file: tests/stubdata/output/datacite-ornldaac-kernel2.2-0010.json modified: tests/test_datacite.py
modified: tests/stubdata/input/datacite-ornldaac-kernel2.2-0010.xml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 91.45% 91.47% +0.02%
==========================================
Files 27 27
Lines 3193 3189 -4
==========================================
- Hits 2920 2917 -3
+ Misses 273 272 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ehenneken
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the DataCite parser's requirement of kernels -3 and -4: the parser can be used with kernel-2 as well. Unit tests with kernel-2.0/2 are included.