Merged
Conversation
modified: adsingestp/parsers/base.py modified: adsingestp/parsers/jats.py modified: pyproject.toml new file: tests/stubdata/input/jats_csp_weird_affil_problem.xml modified: tests/test_jats.py
modified: adsingestp/parsers/jats.py new file: tests/stubdata/output/jats_csp_weird_affil_problem.json
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 91.47% 91.45% -0.02%
==========================================
Files 27 27
Lines 3189 3206 +17
==========================================
+ Hits 2917 2932 +15
- Misses 272 274 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
modified: adsingestp/parsers/base.py
mugdhapolimera
approved these changes
May 6, 2025
Contributor
mugdhapolimera
left a comment
mugdhapolimera
left a comment
There was a problem hiding this comment.
Looks good. delete those extra lines and merge at your convenience
| {"affPubRaw": j, "affPubID": i.get("affid")[idx] if i.get("affid") else []} | ||
| for idx, j in enumerate(i.get("aff", [])) | ||
| ], | ||
| # "affiliation": [ |
Contributor
There was a problem hiding this comment.
delete if not needed
modified: adsingestp/parsers/base.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.