Toggle edit annotation button#838
Merged
thostetler merged 2 commits intoadsabs:masterfrom Apr 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
========================================
+ Coverage 62.5% 62.5% +0.1%
========================================
Files 317 316 -1
Lines 36576 36478 -98
Branches 1673 1672 -1
========================================
- Hits 22827 22789 -38
+ Misses 13709 13649 -60
Partials 40 40 🚀 New features to boost your workflow:
|
thostetler
reviewed
Apr 8, 2026
| onClick={onOpen} | ||
| onClick={onToggle} | ||
| /> | ||
| </Tooltip> |
Member
There was a problem hiding this comment.
In the ticket I was thinking that we should have some visual indication that clicking the button would toggle a menu. Would you mind seeing if you like this type of approach:
<Tooltip label={isOpen ? 'Hide annotation' : 'Show annotation'}>
<IconButton
aria-label={isOpen ? 'Hide annotation' : 'Show annotation'}
aria-expanded={isOpen}
icon={
<HStack spacing="1px" align="center">
<PencilSquareIcon width="18px" height="18px" />
<ChevronDownIcon
boxSize="14px"
transform={isOpen ? 'rotate(180deg)' : 'rotate(0deg)'}
transition="transform 0.2s ease"
/>
</HStack>
}
variant="link"
size="xs"
onClick={onToggle}
/>
</Tooltip>
Composing the icon with a chevron that rotates?
I'm not sure how this would look exactly, haven't tested it, but you get the idea.
fd51976 to
14ab6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-04-08.at.10.06.29.AM.mov