Skip to content

Scix 837 orcid UI update#847

Merged
shinyichen merged 2 commits intoadsabs:masterfrom
shinyichen:SCIX-837-orcid-ui-update
Apr 15, 2026
Merged

Scix 837 orcid UI update#847
shinyichen merged 2 commits intoadsabs:masterfrom
shinyichen:SCIX-837-orcid-ui-update

Conversation

@shinyichen
Copy link
Copy Markdown
Member

  • Update the ORCiD profile panel
    ** Update the orcid id to link to user's orcid public profile page
    ** Add a button that launches search using user's orcid
  • Fix footer text overflow in mobile view
Screenshot 2026-04-14 at 2 59 04 PM Screenshot 2026-04-14 at 2 59 30 PM

Footer Before
Screenshot 2026-04-14 at 3 00 38 PM

Footer After
Screenshot 2026-04-14 at 3 00 53 PM

@shinyichen shinyichen requested a review from thostetler April 14, 2026 22:02
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 9.65517% with 131 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.3%. Comparing base (21ddce5) to head (80ec17b).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/components/images/ScixIconLogo.tsx 5.2% 110 Missing ⚠️
src/components/Orcid/UserSettings.tsx 27.6% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #847     +/-   ##
========================================
- Coverage    62.5%   62.3%   -0.1%     
========================================
  Files         317     318      +1     
  Lines       36576   36714    +138     
  Branches     1673    1672      -1     
========================================
+ Hits        22825   22839     +14     
- Misses      13711   13835    +124     
  Partials       40      40             
Files with missing lines Coverage Δ
src/components/Orcid/UserSettings.tsx 30.2% <27.6%> (-0.2%) ⬇️
src/components/images/ScixIconLogo.tsx 5.2% <5.2%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I like the usage of the scix logo on the "search by" button -- good idea!

@shinyichen shinyichen merged commit 6aaa1e9 into adsabs:master Apr 15, 2026
5 checks passed
@shinyichen shinyichen deleted the SCIX-837-orcid-ui-update branch April 15, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants