adding support for passing cookies to confluence#23
Open
lalkaka wants to merge 4 commits intoadtech-labs:masterfrom
Open
adding support for passing cookies to confluence#23lalkaka wants to merge 4 commits intoadtech-labs:masterfrom
lalkaka wants to merge 4 commits intoadtech-labs:masterfrom
Conversation
Contributor
|
@lalkaka are you still interested in getting this PR into the code base? Would you mind sharing your use case for passing cookies (e.g., what cookies and for what purpose?) so I can better understand if this is a generally useful feature? |
Author
|
Yes, still interested! My company's Confluence instance is on-prem and sits
behind https://www.cloudflare.com/products/cloudflare-access/, which allows
cookies to be passed to get past the SSO interstitial. I believe other
similar zero-trust app gateways (eg from zscaler, Akamai, etc), function in
similar ways.
…On Tue, Mar 12, 2019 at 6:30 AM Peter Parente ***@***.***> wrote:
@lalkaka <https://github.com/lalkaka> are you still interested in getting
this PR into the code base? Would you mind sharing your use case for
passing cookies (e.g., what cookies and for what purpose?) so I can better
understand if this is a generally useful feature?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAm_U5ZV0sM00SIc5DGmZyf8oYgE8nb7ks5vV6vzgaJpZM4af5A7>
.
|
This allows cookies to work as a lone authorization method whereas previously it was required that you entered a username and password every time. Now it will simply attempt to load all three of username, password and cookies from environment variables and use what it gets. The gist of it is that any credentials of the 3 total provided through environment variables or saved in config must be correct, but you are only required to give either username and pass OR cookies.
Add --no-prompt flag to avoid getting username and pass via prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using the CONFLUENCE_COOKIES env var