Override path to css using a environment variable#38
Open
jdlesage wants to merge 1 commit intoadtech-labs:masterfrom
Open
Override path to css using a environment variable#38jdlesage wants to merge 1 commit intoadtech-labs:masterfrom
jdlesage wants to merge 1 commit intoadtech-labs:masterfrom
Conversation
Author
|
Hi @parente |
|
@jdlesage |
Author
|
Hello @caheredia, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I introduce a new env variable NBCONFLUX_NOTEBOOK_CSS to be able to override the default path to notebook.css
We use a lot nbconflux and love it. But on our confluence server, 'https://nbviewer.jupyter.org/' is not whitelisted. Therefore, the confluence server disallow to download the css file.
To workaround this problem, we want to inject into the confluence template a path to a notebook css located on a whitelisted url.