Fix nbconflux for nbconvert>=6.0#47
Conversation
|
Can confirm, that of the existing forks etc, this is the PR that truly works. Verified the operation of this using API Token keys. There are two limitations, however:
Would be a great start to getting around the stale nbconvert problems. However, really need maintainers to come back and give some feedback and/or take one of these PRs. |
|
Can confirm that this fork isn't working properly with |
@chblanc and for anyone else reading this, this branch worked for me today with |
|
@ajstewart I stand corrected. It turns out I accidentally installed the wrong branch. I can now confirm that this is working with |
|
I just checked out the branch from my repo and used it directly from there. You shouldn't need to install anything. |
|
For anyone who wants a quick way to install the branch from this fork this command worked for me
|
Hi, this is related to #45 and #46
I based this off the PR there but ended up fixing the actual issue since I believe the fix didn't quite work as expected since traitlets act a bit oddly if you're not used to them.
I took @makammoun's changes and a fixed it to actually work against a confluence I have access to. I provided the integration test I used, but I couldn't work out how to actually have this work for anyone. It might not be a bad idea to have a nbconflux confluence for vericast so you can run the test in CI.
I have removed the style includes from the confluence templates as this has been deprecated for years now (no more custom style sheets). There were a few minor cleanups too.
You'll probably want to do a new release as 0.7.0 is likely mostly broken for people.