feat: Add unittests #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
filter_sarif.pyfocuses on refactoring the code for better type annotations, readability, and functionality. It also includes new tests to ensure the changes work as expected.Refactoring and Type Annotations:
filter_sarif.py: Added type annotations tomatch_path_and_rule,parse_pattern, andfilter_sariffunctions to improve code readability and maintainability. [1] [2] [3]Functionality and Error Handling:
filter_sarif.py: Improved thefilter_sariffunction to return the filtered SARIF dictionary directly instead of writing to a file. Enhanced error messages for better clarity.Testing Enhancements:
tests/data/cpp.sarif: Added a sample SARIF file for testing purposes.tests/test_filter.py: Created unit tests for thefilter_sariffunction to validate exclusion and inclusion patterns.tests/test_pattern.py: Added unit tests for theparse_patternfunction to ensure correct parsing of patterns.