when >= FILES_MAX, do not use this Plugin, will cost too much time.#1
when >= FILES_MAX, do not use this Plugin, will cost too much time.#1uvery9 wants to merge 2 commits intoadyanth:mainfrom
Conversation
|
Hey @JareddC thanks for the PR! Had a question here. How did you choose the value for |
| IEnumerable<string> subDirs = Directory.EnumerateDirectories(rootPath); | ||
| foreach (string dir in subDirs) | ||
| { | ||
| if (foundFiles.Count() < FILES_MAX) |
There was a problem hiding this comment.
Could you break (or even return) if the condition fails, so that each recursive call can travel up as soon as it exceeds FILE_MAX?
There was a problem hiding this comment.
Less than FILES_MAX, just return the file count of folders. Use try, catch to catch UnauthorizedException and so on.
There was a problem hiding this comment.
Sorry, I did not get it.
What I am trying to say is, if the condition fails, and the count exceeds, add an else block to either break or return so that we stop additional looping.
This is my point of view. |
|
Oh, do you mean more than 300 files in the same directory? If that is the case, correct, it is not really appropriate. But, it is not appropriate for that subfolder if it was inside. Do we not want to show the parent folder too in that case? I will try once with your patch when I have time to see the behaviour and will let you know. |
|
fix pack-zip.ps1 error by |
|
Here is an example, there are no folders with more than 300 files here. I would really like to be able to open the folder to go to the bin folder and open the executable directly. Seems too limiting. If it was a limit of 300 files only in that folder, I would see that making sense. But then, it would need to have lazy loading as and when sub folders are expanded to have any advantage.
If you would like to use it, here is the link to the build. Let me know if it suits you. At this point, I do not feel it is a useful limitation to impose. Let me know if you have other thoughts on this. |
|
When there are dozens(may be just 30) of video files in the folder, this plugin will be really slow |
|
Okay, just verified that now, it is true. Looks like the thumbnail generation takes time for video files. @mooflu thoughts on this issue? |
2 participants
when >= FILES_MAX, do not use this Plugin, will cost too much time.