This repository was archived by the owner on Dec 30, 2019. It is now read-only.
Raise SSL errors and respect action mailer's :enable_starttls_auto setting #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into the exact same issue. I'd like to see this fix merged too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ran into problems using ar_sendmail with a mail server that can use tls, but doesn't have a valid certificate, and made a couple of changes to the code as a result...
SSL errors are no longer silently ignored, and action mailer's new(ish) :enable_starttls_auto is respected within ActionMailer::ARSendmail#deliver
These changes seem sensible to me, you may wish to pull them in if you agree.
Mark