Fix ExtendedPlayerInventory poor performance#122
Open
ActuallyAdasi wants to merge 1 commit intoaedenthorn:masterfrom
Open
Fix ExtendedPlayerInventory poor performance#122ActuallyAdasi wants to merge 1 commit intoaedenthorn:masterfrom
ActuallyAdasi wants to merge 1 commit intoaedenthorn:masterfrom
Conversation
This was due to constant exception handling (Null Pointer Exception). This commit has no functional changes other than adding null pointer checks where the constant null pointer exception handling was occuring.
Author
|
Let me know if I can take steps to release this on r2modman as well, right now I'm just sharing the resulting dll with the players in my server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
ExtendedPlayerInventory tanks client performance.
This was due to constant exception handling (Null Pointer Exception).
This commit has no intended functional changes other than adding null pointer checks where the constant null pointer exception handling was occuring.
The unintended functional change is the v, b, n UI moves from the center of the screen (which I do not believe is by design), to the left of the screen, vertically centered (see screenshots below).
I can provide more version, mod details if needed, but given the safety of these changes, I don't find it necessary.
Testing
Before:
After:
(Errors no longer spamming the logs)