Merged
Conversation
Daihecyy
approved these changes
Dec 23, 2024
Contributor
Daihecyy
left a comment
Daihecyy
left a comment
There was a problem hiding this comment.
Agreed only from a technical standpoint, consider thoroughly if such a bump is need
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
We really need to release new versions soon, as we have not for several months and there's some time needed to test in alpha before prod.
This goes hand in hand with the major version bump for Titan.
Both PRs are ready, and seemingly waiting for some more breaking changes to be merged, including (by likelihood):