Skip to content

Remove requests, use httpx for sync and async HTTP requests #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marc-Andrieu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove requests, use httpx for sync and async HTTP requests #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77b6abd
Send logs to Matrix asynchronously
Marc-Andrieu Oct 14, 2025
0b13517
Remove `requests` from direct dependencies, promote `httpx` to common…
Marc-Andrieu Oct 14, 2025
5e16854
Use httpx synchronously: no propagation of async/await pattern
Marc-Andrieu Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/utils/communication/matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any

import requests
import httpx

from app.types.exceptions import MatrixRequestError, MatrixSendMessageError

Expand Down Expand Up @@ -43,10 +43,15 @@ def post(
if "Authorization" not in headers:
headers["Authorization"] = "Bearer " + self.access_token

response = requests.post(url, json=json, headers=headers, timeout=10)
try:
response = httpx.post(
url,
json=json,
headers=headers,
timeout=10,
)
response.raise_for_status()
except requests.exceptions.HTTPError as err:
except httpx.RequestError as err:
raise MatrixRequestError() from err

return response.json()
Expand Down
1 change: 0 additions & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,3 @@ types-Authlib==1.5.0.20250516
types-fpdf2==2.8.3.20250516
types-psutil==7.0.0.20250601
types-redis==4.6.0.20241004
types-requests==2.32.0.20250515
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ PyMuPDF==1.26.6 # PDF processing, imported as `fitz`
pypdf==6.4.0
python-multipart==0.0.18 # a form data parser, as oauth flow requires form-data parameters
redis==5.0.8
requests==2.32.4
sqlalchemy-utils == 0.41.2
SQLAlchemy[asyncio]==2.0.44 # [asyncio] allows greenlet to be installed on Apple M1 devices.
unidecode==1.3.8
Expand Down
Loading