-
Notifications
You must be signed in to change notification settings - Fork 6
Enable WebAssembly compilation #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0cb9653
Dependencies
Marc-Andrieu b1fd3c0
Headers compatible with WASM-multithreading + no cross-origin isolation
Marc-Andrieu 0dddc43
It works, at last (but tests shall fail)
Marc-Andrieu f26747d
Nginx fixes
Marc-Andrieu a29574d
It works, we shall not touch this code anymore, it is a miracle of Na…
Marc-Andrieu 99283e1
Code quality: named params
Marc-Andrieu 2acb6ac
Fix: remove the old ways that I had commented
Marc-Andrieu 0a1c4ab
Fix: otherwise the conversion from event.data to a string fails stati…
Marc-Andrieu 919880f
Add the `--wasm` flag where it should be used
Marc-Andrieu d138106
Fix: helloAssoCallback name
Marc-Andrieu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM nginx:1.28.0-alpine3.21-slim | ||
| FROM nginx:1.28.2-alpine3.23-slim | ||
| COPY nginx.conf /etc/nginx/nginx.conf | ||
| COPY ./build/web/ /app/html | ||
| RUN find /app/html/ -type f -size +512c -regex '.*\.\(html\|css\|js\|json\|svg\|ttf\|otf\|woff2\|wasm\|mjs\|symbols\|yaml\|env\)' -exec gzip -k9 {} + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import 'dart:async'; | ||
|
|
||
| void webWindowWithCallback( | ||
| String windowUrl, | ||
| String windowName, { | ||
| required void Function() completerFutureCallback, | ||
| required Future<void> Function(String) loginCallback, | ||
| }) async => throw UnsupportedError( | ||
| "`webWindowWithCallback()` is not implemented for the current platform", | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import 'dart:async'; | ||
| import 'package:universal_html/universal_html.dart'; | ||
|
|
||
| void webWindowWithCallback( | ||
| String windowUrl, | ||
| String windowName, { | ||
| required void Function() completerFutureCallback, | ||
| required Future<void> Function(String) loginCallback, | ||
| }) async { | ||
| WindowBase popupWin = window.open( | ||
| windowUrl, | ||
| windowName, | ||
| "width=800, height=900, scrollbars=yes", | ||
| ); | ||
|
|
||
| final completer = Completer(); | ||
| void checkWindowClosed() { | ||
| if (popupWin.closed == true) { | ||
| completer.complete(); | ||
| } else { | ||
| Future.delayed(const Duration(milliseconds: 100), checkWindowClosed); | ||
| } | ||
| } | ||
|
|
||
| checkWindowClosed(); | ||
| completer.future.then((_) => completerFutureCallback()); | ||
|
|
||
| window.onMessage.listen((event) { | ||
| final data = event.data.toString(); | ||
| if (data.contains('code=')) { | ||
| loginCallback(data); | ||
| popupWin.close(); | ||
| } | ||
| }); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.