Skip to content

perf: network optimizations#108

Open
orangishcat wants to merge 36 commits intoaehmttw:masterfrom
orangishcat:network-optimization-cleaned
Open

perf: network optimizations#108
orangishcat wants to merge 36 commits intoaehmttw:masterfrom
orangishcat:network-optimization-cleaned

Conversation

@orangishcat
Copy link
Contributor

@orangishcat orangishcat commented Sep 10, 2025

deletes half the codebase

  • Reflection handler to populate event fields without additional code
  • Trimmed all doubles to floats and some ints to shorts
  • Changed Game.networkRate from 60 to 20
  • Overall, reduced network traffic (upstream/downstream) by around 80%

@orangishcat
refactor: create NetworkHandler for shared properties
7e13d4c 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
feat: network optimizations, reflection handlers
1a24258 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: network event fixes
dc4832d 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
perf: use shorts for colors
fb7aec3 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix(network): network-related bug fixes
f45056b 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix(EventTankUpdateHealth): shield fix
7057b13 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
style: minor code style changes
5584102 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: shoot bullet event
817e29f 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: remove stacked group event
6c39fa7 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
feat: more network validation checks
c60e604 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: interpolation bug
ddda007 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: more interpolation bugs
096f35e 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
Copy link
Contributor Author

orangishcat commented Sep 10, 2025

Marking as draft as there are still strange interpolation issues i need to fix (will do tmrw)

@orangishcat
fix: explosion bug
c1082d4 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: partial angle interpolation fix
8073cbc 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: duplicate obstacle destroy events from explosion
db1605a 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
refactor: extract duplicate code
60b3738 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: preserve order by batching all events
cf18fbb 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix,style: make more events stackable, optimize imports
8fc13e4 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
perf: make instant waypoint events stackable
f92fab3 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
perf: optimize network load of 0 cooldown items
d4a8853 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: change debug option back to false
b8b0483 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat orangishcat marked this pull request as ready for review September 14, 2025 06:44
@orangishcat
fix: stack bullet events only for zero cooldown shots
455f8c5 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: continuous shooting only for low cooldown bullets,
0d47c5c 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: set event data debug to false
a8dfed6 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
perf: use int for quick actions encoding
3ff9442 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
Copy link
Contributor Author

orangishcat commented Sep 15, 2025

Additional changes and stuff to test:

  • Explosions now destroy properly on client side, don't emit duplicate destroy events (thanks furret)
  • Stackable events are placed in linked hash maps to preserve stacked event order
  • Applied continuous shooting to bullets with less than 10 cooldown
  • Made bullet shoot and bullet destroy events stackable for bullets with zero cooldown
  • Added EventSetItemCount to replace EventSetItem when only the count of the item has changed
  • Made a bunch more events stackable to reduce network load
  • Added Game.recordEventData "Record event data" debug option to record network KB/s of each event every second
  • Quick actions is now sent through the network encoded as an int (thanks F6)
  • Fixed EventTankUpdateHealth to display the correct health value at all times
  • Added validation upon game launch of network events to ensure every read call is paired with a write call
  • Extracted duplicate functionality in ServerHandler and ClientHandler into NetworkHandler
  • Probably more that I forgot about

Also double check interpolation so that the tank id 0 tank isn't stuck in the corner or anything

@orangishcat orangishcat changed the title feat: network optimizations perf: network optimizations Sep 15, 2025
@orangishcat
Merge branch 'remote-master' into network-optimization-cleaned
c91254a 
# Conflicts:
#	src/main/java/tanks/Game.java
#	src/main/java/tanks/hotbar/ItemBar.java
#	src/main/java/tanks/network/event/EventSetItemCount.java
#	src/main/java/tanks/network/event/EventTankUpdateHealth.java
@orangishcat
chore: update branch
6db2cf0 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: event lay mine
b5f74cf 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
aehmttw
aehmttw reviewed Dec 1, 2025
View reviewed changes
aehmttw
aehmttw reviewed Dec 1, 2025
View reviewed changes
@aehmttw
Copy link
Owner

aehmttw commented Dec 1, 2025

Screen Shot 2025-12-01 at 2 23 11 AM (2) the tank health is not consistent

@orangishcat
fix: sounds not playing on client side
0b6a164 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
fix: add sounds back, fix tank health inconsistency
d96c4cf 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
Merge branch 'remote-master' into network-optimization-cleaned
8d98c11 
# Conflicts:
#	src/main/java/tanks/Game.java
@orangishcat
chore: update branch
058a962 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
Merge branch 'remote-master' into network-optimization-cleaned
188b8d4 
# Conflicts:
#	src/main/java/tanks/hotbar/ItemBar.java
#	src/main/java/tanks/network/event/EventAddNPCShopItem.java
#	src/main/java/tanks/network/event/EventAddShopItem.java
#	src/main/java/tanks/network/event/EventSortShopButtons.java
@orangishcat
chore: update branch, fix build errors
f7c9d1d 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
@orangishcat
Merge branch 'remote-master' into network-optimization-cleaned
b4d0125 
# Conflicts:
#	src/main/java/tanks/network/event/EventExplosion.java
@orangishcat
chore: merge Explosion.java
a5e5e57 
Signed-off-by: orangishcat <fdsnail2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aehmttw aehmttw aehmttw left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orangishcat @aehmttw