Fix: If Target returns an empty offers array#9
Open
jfoxx wants to merge 2 commits intoaemsites:targetfrom
Open
Fix: If Target returns an empty offers array#9jfoxx wants to merge 2 commits intoaemsites:targetfrom
jfoxx wants to merge 2 commits intoaemsites:targetfrom
Conversation
If an activity is active on the page, but the audience is not met, Target returns an empty array for the offers. This prevents that from bombing the rest of the page.
Add check for empty content in options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an activity is active on the current page, but the audience is not met, Target will return an empty array for "content" in the json. When this happens, the page stops rendering.
This fix adds one line that just ensures the content node is not empty.